Fixed download url to compatible composer version 1.0.0-alpha7. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore this pull request... Seems like certain packages make the eclipse plugin fail to setup build path, regardless of composer version. |
|
@b4cedev Thanks for the hint with failing build path. May it be, that these packages have a custom install path? (because this is at the moment not possible to recognize them automatically pulse00/Composer-Eclipse-Plugin#74) If not please open an issue at the Composer-Eclipse-Plugin project at github, describing the problem with the build path and these certain packages. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current composer version fetched by the original url includes changes that make the eclipse plugin generate an empty build path, so i changed download url to last compatible version (1.0.0-alpha7).
Since more than the eclipse plugin may be using the PharDownloader it would be desirable to make the version to be downloaded configurable...