Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream PULPv2 features #66

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Upstream PULPv2 features #66

wants to merge 20 commits into from

Conversation

sermazz
Copy link

@sermazz sermazz commented Feb 19, 2025 •
edited
Loading

This pull request cleans up and puts together the commits of the following branches

that can now be deleted.

From the previous (never merged) PR #49:

  • register frontend now supports setting source and destination protocols
  • legalizer is instantiated correctly (before it would never use bursts when any used protocol did not support it)
  • register frontend correctly sets number of N-D repetitions when not using the maximum number of dimensions
  • some compilation/optimization fixes (specific to vopt)

The pulp_idma_wrap is also moved from here to the PULP Cluster repository, following the same approach of Astral.

thommythomaso and others added 20 commits February 19, 2025 12:26
@thommythomaso @sermazz
Multichannel PULP DMAC
64d1856
@da-gazzi @sermazz
[WIP] rename dmac_wrap
0b05ab8
@da-gazzi @sermazz
[WIP] PULP iDMA wrap: allow mux of rd ports, use axi structs
bc73750
@da-gazzi @sermazz
[WIP] add generated iDMA code to allow bender inclusion
cbfbfcf
@da-gazzi @sermazz
[WIP] change inst64_snitch_pkg bender target to only rtl
9a7f04d
@da-gazzi @sermazz
[WIP] fix compilation errors in pulp_idma_wrap
c5f106b
@da-gazzi @sermazz
[WIP] Fix compilation & optimization of PULP iDMA wrap, register FE
da53f41
@da-gazzi @sermazz
change tagged meta req assignment to always_comb bc of vopt issues
19d3482
@da-gazzi @sermazz
reg FE: fix ctrl response handshk and dim assignments
bff980f
@da-gazzi @sermazz
fix number of protocol bits and location
f5248bf
@da-gazzi @sermazz
fix legalizer generation when burst and non-burst protocols combined
c273197
@da-gazzi @sermazz
PULP iDMA wrap passes simple tests and is not unnecessarily slow
8980abd
@da-gazzi @sermazz
PULP DMA wrapper: INIT channel response is always valid
1aa014f
@da-gazzi @sermazz
PULP DMA wrap: fix INIT read/write with spill registers
118eb82
@da-gazzi @sermazz
INIT read: only assign buffer_in_valid_o if datapath req valid
727c873
@da-gazzi @sermazz
change HCI "master" to "initiator"...
78f6883
@da-gazzi @sermazz
remove assignment to no-longer-used HCI signals
252ab63
@da-gazzi @sermazz
add TCDM_MEM2BANKS parameter to pulp iDMA wrap
6e89408
@da-gazzi @sermazz
Prepare for PR
7d22af9 
- move pulp_idma_wrap to PULP Cluster repo
- remove generated files
- fix white spaces
@micprog @sermazz
Fix lint
262c59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thommythomaso thommythomaso Awaiting requested review from thommythomaso thommythomaso will be requested when the pull request is marked ready for review thommythomaso is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sermazz @thommythomaso @da-gazzi @micprog