Skip to content

Conversation

@honeykhatri
Copy link

@honeykhatri honeykhatri commented Jul 24, 2019

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- see README.md for how to run them
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Please alert developers on [email protected] when your request is ready or if you need assistance.

Thanks!

@welcome
Copy link

welcome bot commented Jul 24, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@sidntrivedi012
Copy link
Member

Hey @honeykhatri ,

@Lionel-Stewart has already sent a patch for this issue at #114 . But, its really great that you reached out to help us. We appreciate it a lot. There are a lot of first-timers-only issues waiting to be solved and taken up not only in this project but many other interesting projects of Public Lab. You can find them in our Community Toolbox - https://code.publiclab.org . Go ahead.

Thanks 🎉 🎈 🔬 🚀

Copy link
Member

@starkblaze01 starkblaze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @honeykhatri thanks for contributing in PL. As @sidntrivedi012 said we already have #114 . We would love to have you collaborate that PR.

@sidntrivedi012
Copy link
Member

@starkblaze01, Should we close this PR for now?

@sidntrivedi012
Copy link
Member

@jywarren Should we close this PR?
/cc: @starkblaze01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants