Opacities action #1260
Opacities action #1260
Conversation
…leImage into OpacitiesAction
|
Does anyone like this code? haha I feel lonely! ;) |
Hey! I like your code. Nice work 👏 |
|
@themacboy Its great!! PS. glad you reopened it 🙌🏾🙌🏾 |
|
I'm currently using CSSStyleSheet to define my css overrides... but that's too modern and not all browsers have a correct implementation. Then I'm not sure about changing it to the traditional <style> tag. |
…leImage into OpacitiesAction
|
can you merge in the project?. Thanks! |
There was a problem hiding this comment.
Hi, sorry for my slow review here, been busy! Much appreciated, this looks really cool, and I love the new icon!
Just to clarify, is this on by default in one of the examples? Also, a Q below about the CDN leaflet. We could upgrade Leaflet itself if that's preferable to switching to a CDN.
examples/index.html
Outdated
| @@ -6,12 +6,12 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no"/> | |||
| <meta http-equiv="x-ua-compatible" content="ie=edge"/> | |||
|
|
|||
| <link rel="stylesheet" href="../node_modules/leaflet/dist/leaflet.css"> | |||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.9.2/leaflet.min.css"> | |||
There was a problem hiding this comment.
Here, i'm not against pegging a specific version via CDN, but was this necessary to make this work? Just curious if we could remove this to simplify the PR. Thanks!
There was a problem hiding this comment.
Hello ! Im alive !!!
Thx for your all yout comments !
The reason for moving to CDN was due to Github Pages service is failing when trying to load local files (missing files).
Then I couldn't test my changes on the web, lol, that's the only reason for this change.
There was a problem hiding this comment.
If needed I can set local method before the final merge ;)
There was a problem hiding this comment.
Oh that would be great to revert this back to the local one. We use that in our gh-pages demo. Thank you!
examples/index.html
Outdated
| <link rel="stylesheet" href="../dist/vendor.css"> | ||
| <link rel="stylesheet" href="../dist/leaflet.distortableimage.css" media="screen" title="no title"> | ||
| <link rel="stylesheet" href="https://unpkg.com/leaflet-control-geocoder/dist/Control.Geocoder.css" /> | ||
|
|
||
| <script src="../node_modules/leaflet/dist/leaflet.js" type="text/javascript" charset="utf-8"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.9.2/leaflet.js" type="text/javascript" charset="utf-8"></script> |
|
Also, THANK YOU for such great video documentation, live example, tidy code, and adjustments to the tests! |
|
And just one final question - is this on by default in one of the examples? Thanks! |
|
(i see you adjusted the CDNs so otherwise approved! Thanks!) |
|
@jywarren update with updating new commits. |
|
Thanks!! Just wanted to know that last question -- is this on by default in one of the examples? Thanks! |
yes ! I think it is. |
|
Wonderful, thank you!!!!! |
Fixes #311
First of all, sorry for my poor English and weak coding skills (I do it just for fun!)
I was working on a new action to set custom and variable opacity.
Please check the video for more details:
You can play it:
Opacities Action example page