Tidy test/integration go.mod after root module dep bumps#2
Merged
Conversation
Adding golangci-lint and gofumpt to the root module bumped several
indirect dependencies (golang.org/x/{mod,sync,sys,text,tools},
google/go-cmp, sirupsen/logrus). The integration test sub-module uses a
local replace for github.com/pthm/orchard, so it inherits those
transitive deps from the root and its own go.mod fell out of sync.
`go test` refuses to run with the "updates to go.mod needed; run go mod
tidy" error, which is why the integration-tests job exited with code 1
in ~16 seconds before any container could start.
https://claude.ai/code/session_01M7965nBDKbuuCb78mSPAB3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding golangci-lint and gofumpt to the root module bumped several
indirect dependencies (golang.org/x/{mod,sync,sys,text,tools},
google/go-cmp, sirupsen/logrus). The integration test sub-module uses a
local replace for github.com/pthm/orchard, so it inherits those
transitive deps from the root and its own go.mod fell out of sync.
go testrefuses to run with the "updates to go.mod needed; run go modtidy" error, which is why the integration-tests job exited with code 1
in ~16 seconds before any container could start.
https://claude.ai/code/session_01M7965nBDKbuuCb78mSPAB3