Skip to content

Slight re-wording/text inserts #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YeahJenni wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Slight re-wording/text inserts #651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f30ca6
Added COMPOSER_ALLOW_SUPERUSER=1 into Panel Upgrade
YeahJenni Feb 13, 2025
706b77e
Added more clarification on 127.0.0.1 allocations
YeahJenni Feb 13, 2025
1c56773
Should be done, changed a bit more
YeahJenni Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panel/1.0/updating.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ After you've downloaded all of the new files you will need to upgrade the core c
simply run the commands below and follow any prompts.

```bash
composer install --no-dev --optimize-autoloader
Copy link
Contributor

@WeeskyBDW WeeskyBDW Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think it's a good idea to recommend that because it's a security risk and afaik not needed in 99% of the cases (and if needed then they prob is a file perm issue)

Copy link
Author

@YeahJenni YeahJenni Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it there to try and follow through with the first install segment, as that has the same thing too, and I feel it sometimes causes issues for people

Copy link
Contributor

@WeeskyBDW WeeskyBDW Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it as change though but if it's added prob add a warning on the impact of that env var

Copy link

@EgoMaw EgoMaw Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As composer's own documentation states, composer shouldn't be run as root.
Instead of arbitrarily ignoring the warning, it's perhaps best to guide people to composer's documentation instead, although, I don't believe it should be up to pterodactyl's documentation to solve every single problem unrelated to pterodactyl itself.

https://getcomposer.org/doc/faqs/how-to-install-untrusted-packages-safely.md#why-am-i-seeing-a-do-not-run-composer-as-root-super-user-warning-error-

The catch-all phrase under getting started should apply to this:
If you expect to be able to install this with no understanding of basic linux system administration you should stop and turn around now.

Copy link
Contributor

@rowansc1 rowansc1 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, composer do not recommend running as root, and we don't recommend people do. Sometimes people do so, and it's fine, but we shouldn't recommend it.
When running the existing command as root, people are given an option to proceed anyway. Thanks though!

COMPOSER_ALLOW_SUPERUSER=1 composer install --no-dev --optimize-autoloader
```

### Clear Compiled Template Cache
Expand Down
2 changes: 1 addition & 1 deletion wings/1.0/installing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,4 @@ Allocation is a combination of IP and Port that you can assign to a server. Each

![example image of node allocations](../../.vuepress/public/node_allocations.png)

Type `hostname -I | awk '{print $1}'` to find the IP to be used for the allocation. Alternatively, you can type `ip addr | grep "inet "` to see all your available interfaces and IP addresses. Do not use 127.0.0.1 for allocations.
Type `hostname -I | awk '{print $1}'` to find the IP to be used for the allocation. Alternatively, you can type `ip addr | grep "inet "` to see all your available interfaces and IP addresses. Do not use 127.0.0.1 for allocations, *unless you know what you are doing/using a [Minecraft Proxy](https://pterodactyl.io/community/games/minecraft.html)*.
Copy link
Contributor

@WeeskyBDW WeeskyBDW Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more general link to proxy, because even if ptero seems a lot used for Miencraft it's not the only game hosted

Copy link
Author

@YeahJenni YeahJenni Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik the most common use for proxies with Pterodactyl is Minecraft, and so far it is the only one with a community guide

Copy link
Contributor

@rowansc1 rowansc1 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword this to something like "unless you're using a proxy, such as a minecraft proxy (link)? Open to suggestions. That way it doesn't just mean it only applies to Minecraft Proxies, because that's not true.