Some clean ups around sceGu
#285
Conversation
| }; | ||
|
|
||
| /** Values for retro compatibility */ | ||
| #define PSP_DISPLAY_SETBUF_IMMEDIATE PSP_DISPLAY_SETBUF_NEXTHSYNC |
There was a problem hiding this comment.
Keeping previous values for retro compatibility
| @@ -116,7 +116,7 @@ extern GuLightSettings light_settings[4]; | |||
|
|
|||
| void callbackSig(int id, void *arg); | |||
| void callbackFin(int id, void *arg); | |||
| void resetValues(); | |||
| void _sceGuResetGlobalVariables(); | |||
There was a problem hiding this comment.
Use better function name to avoid name conflicts when linking the binary.
src/gu/sceGuFinishId.c
Outdated
There was a problem hiding this comment.
The same content was before in sceGuFinish
src/gu/sceGuInit.c
Outdated
There was a problem hiding this comment.
Improving sceGuInit now it has better error check
| GuContext *context = &gu_contexts[ctype]; | ||
| unsigned int *local_list = (unsigned int *)(((unsigned int)list) | 0x40000000); | ||
|
|
||
| intr = sceKernelCpuSuspendIntr(); |
There was a problem hiding this comment.
Is this expensive to do? Do we have a chance to lose input because of this?
There was a problem hiding this comment.
it shouldn't be expensive, is the best way to assure atomic operations
|
|
||
| if (!gu_object_stack_depth && !gu_curr_context) | ||
| sceGeListUpdateStallAddr(ge_list_executed[0], gu_list->current); | ||
| static inline int _sceGuUpdateStallAddr(void) { |
There was a problem hiding this comment.
So if I understand correctly the stalli function was used to make sure that if you are using direct mode, the function you called before cannot be interrupted? This looks more readable, but I do wonder how this looks in cpu cycles.
There was a problem hiding this comment.
I think the GCC compiler is clever enough like to put the exactly same ASM code as before
Description
Some improvements and clean-ups in
sceGu:PspDisplaySetBufSyncsceGuFinishandsceGUFinishIdsendCommandiStallfunction, it was previously adding the command and then updating the stall address, now we have a new function called_sceGuUpdateStallAddrwhich updates the stall address.sceGuInitsceGuCallListresetValuesto_sceGuResetGlobalVariables, which is a more appropriate name for a "kind of private function"sceGuInitby being sure we cover failure scenarios and make it more robust for concurrency scenarios.sceGuSendListCheers!