Repository navigation
Fix wheel packaging to include xtalpaint subpackages - #80
Merged
Merged
Conversation
The static `packages = ["xtalpaint"]` list only declared the top-level package, so setuptools built wheels containing `src/xtalpaint/*.py` and nothing else. Subpackages such as `xtalpaint.aiida` were silently omitted, breaking non-editable installs and the aiida.data entry points that reference `xtalpaint.aiida.data`. Editable installs masked this because they import straight from the source tree. Replace the static list with automatic discovery via `[tool.setuptools.packages.find]`, which picks up all subpackages under `src/`. The `where` setting supersedes the previous `package-dir` mapping, so both are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static
packages = ["xtalpaint"]list only declared the top-level package, so setuptools built wheels containingsrc/xtalpaint/*.pyand nothing else. Subpackages such asxtalpaint.aiidawere silently omitted, breaking non-editable installs and the aiida.data entry points that referencextalpaint.aiida.data. Editable installs masked this because they import straight from the source tree.Replace the static list with automatic discovery via
[tool.setuptools.packages.find], which picks up all subpackages undersrc/. Thewheresetting supersedes the previouspackage-dirmapping, so both are removed.