Do not verify block signature on block processing #14820
+14
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested changes
Jan 22, 2025
There was a problem hiding this comment.
This breaks the Beacon API implementation: https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/publishBlockV2. If broadcast_validation: consensus is specified, the signature is expected to be verified before broadcasting.
To summarize:
- Propose using the Prysm API: broadcast without verifying
- Propose using the Beacon API with default settings: broadcast without verifying
- Propose using the Beacon API with
broadcast_validation: consensus: verify before broadcasting
You will need to add a separate check here:
prysm/beacon-chain/rpc/eth/beacon/handlers.go
Line 1164 in e36564c
potuz
force-pushed
the
dont_check_block_signature_on_processing
branch
from
12517d4 to
a63a278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying the block signature adds a batch and performs a full hash of the block unnecessarily.