Handle Networking Message Limits Better #14799
Open
+74
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
previously approved these changes
Jan 16, 2025
…s/geth-sharding into handleMessageLimits
potuz
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Spec Clarification
What does this PR do? Why is it needed?
This PR handles the clarification in the networking spec on gossip and rpc message limits. We remove the previous config values which are deprecated and now use
MaxPayloadSizein place. We have also fixed our rpc and gossip encoders to handle these changes.This tracks this PR in the Consensus Spec Repo
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements