Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the potentially inconsistent issue. #14700

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The format is based on Keep a Changelog, and this project adheres to Semantic Ve
- Update our `go-libp2p-pubsub` dependency.
- Re-organize the content of files to ease the creation of a new fork boilerplate.
- Fixed Metadata errors for peers connected via QUIC.
- Fixed the potential issues of inconsistency that might arise during the processing of engine_exchangeCapabilities. [PR](https://github.com/prysmaticlabs/prysm/pull/14700)

### Deprecated

Expand Down
9 changes: 4 additions & 5 deletions beacon-chain/execution/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -915,13 +915,12 @@ func (c *capabilityCache) save(cs []string) {
c.capabilitiesLock.Lock()
defer c.capabilitiesLock.Unlock()

if c.capabilities == nil {
c.capabilities = make(map[string]interface{})
}

capabilities := make(map[string]interface{})
for _, capability := range cs {
c.capabilities[capability] = struct{}{}
capabilities[capability] = struct{}{}
}

c.capabilities = capabilities
}

func (c *capabilityCache) has(capability string) bool {
Expand Down