Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Conversation

@Aswath2481
Copy link

@Aswath2481 Aswath2481 commented Jul 8, 2020

The following files were proposed to be used in the RDK-B system of RPi to be able to start the prplmesh automatically during bootup.
A recipe must be made to install these files to their correct location during the build.
Signed-off-by: aswath [email protected]

https://jira.prplfoundation.org/browse/PPM-245

@MuteSpirit MuteSpirit added the don't merge This PR is not ready for merge or review label Jul 10, 2020
@MuteSpirit MuteSpirit self-requested a review July 10, 2020 22:07
@VladyslavTupikin VladyslavTupikin self-requested a review July 11, 2020 07:43
@VladyslavTupikin
Copy link
Collaborator

@Aswath2481 Can you please add PR description and fix commit message according to the CONTRIBUTING.md file?

ExecStart=/bin/bash /bin/prplmesh_startup.sh

[Install]
WantedBy=multi-user.target No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a newline at the end of the file.

Copy link
Collaborator

@MuteSpirit MuteSpirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prplmesh_startup.sh

I think this file is not needed at all
Try to add next for force systemd start hostapd itself

Requires=hostapd.service

It's more general solution because hostapd.service unit will run hostapd for all available wlanX interfaces

prplmesh_startup.service

  • missing license banner
  • Use prplMesh instead of Prpl in Description
  • If see on another systemd units in RDKB then more offten you may find that for start scripts using next:
Type=forking
ExecStart=/bin/sh -c '/path/to/script/to/run script args'

So i suggest to not use oneshot type

  • To enable logging please add
StandardOutput=syslog+console
After=syslog.target

prplmesh-systemd.bb

This recipe is absent. Please add it to install and activate systemd unit for prplMesh

Looking for example of such recipes by grepping variable SYSTEMD_SERVICE_${PN} among RDKB recipes

Also add name of this recipe into packagegroup-prplmesh for case when systemd is in DISTRO_FEATURES

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

don't merge This PR is not ready for merge or review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants