Skip to content

Conversation

@proxyles
Copy link
Owner

No description provided.

@proxyles proxyles force-pushed the henrik/failed-commit-msg branch 2 times, most recently from 1a580b7 to 1b0ad84 Compare October 24, 2014 10:11
@OTP-Maintainer
Copy link

Detta är ett bra meddelande, nej bara skojja det är skitlångt.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Detta är ett bra meddelande, nej bara skojja det är skitlångt.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message:Detta är ett bra meddelande, nej bara skojja det är skitlångt.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande, nej bara skojja det är skitlångt.


I am a script, I am not human


@proxyles proxyles force-pushed the henrik/failed-commit-msg branch from 1b0ad84 to ebaa949 Compare October 24, 2014 13:25
@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@proxyles proxyles force-pushed the henrik/failed-commit-msg branch from ebaa949 to 56c4df3 Compare October 24, 2014 13:45
@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@proxyles proxyles force-pushed the henrik/failed-commit-msg branch from 56c4df3 to 3e6bb12 Compare October 24, 2014 13:52
@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande...


I am a script, I am not human


sakjfasölkfna
asfdksaölfkmnsaöfm
@proxyles proxyles force-pushed the henrik/failed-commit-msg branch from 3e6bb12 to d5ce7c3 Compare October 24, 2014 13:55
@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


5 similar comments
@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Detta är ett bra meddelande.


I am a script, I am not human


proxyles pushed a commit that referenced this pull request Sep 30, 2015
Main problem:
A faulty HIPE_LITERAL_CRC was not detected by the loader.

Strangeness #1:
Dialyzer should ask the hipe compiler about the target checksum,
not an internal bif.

Strangeness #2:
The HIPE_SYSTEM_CRC checksum was based on the HIPE_LITERALS_CRC
checksum.

Solution:
New HIPE_ERTS_CHECKSUM which is an bxor of the two (now independent)
HIPE_LITERALS_CRC and HIPE_SYSTEM_CRC.

HIPE_LITERALS_CRC represents values that are assumed to stay constant
for different VM configurations of the same arch, and are therefor
hard coded into the hipe compiler.

HIPE_SYSTEM_CRC represents values that may differ between VM variants.
By default the hipe compiler asks the running VM for this checksum,
in order to create beam files for the same running VM.
The hipe compiler can be configured (with "make XCOMP=yes ...") to
create beam files for another VM variant, in which case HIPE_SYSTEM_CRC
is also hard coded.

ToDo:
Treat all erts properties the same. Either ask the running VM or hard
coded into hipe (if XCOMP=yes). This will simplify and reduce the risk
of dangerous mismatches. One concern might be the added overhead
from more frequent calls to hipe_bifs:get_rts_param.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants