Fix #30: server.region matches the chosen cloud provider

[obaid]

Summary

The servers.region column had a Hetzner-centric migration default ('nbg1'), and the three call sites that insert Server rows all omitted region from the create payload. A team provisioned on DigitalOcean therefore ended up with server.region='nbg1' even though the droplet was actually created in 'nyc1' (the DO job hardcodes its own region from config('cloud.regions.us-east.digitalocean')).

Mostly cosmetic — the DO API ignores our column — but it misrepresented the actual provider in dashboards / Telescope / observability, and any future code that reads server.region to call provider APIs would break.

Fixes #30.

Changes

• app/Enums/CloudProvider.php: new defaultProviderRegion() that returns the provider-specific code:

  • DigitalOcean → 'nyc1'
  • Hetzner → 'ash'
  • Linode → 'us-east'
  • Docker → 'local'

  Reads from cloud.regions.us-east.<provider> config first (so any deploy-level region remap works), falls back to hardcoded per-provider defaults if config is missing.

• app/Http/Controllers/Settings/TeamController::provisionServer: set region from $cloudProvider->defaultProviderRegion() when creating the Server row.

• app/Http/Controllers/AgentController::ensureTeamHasServer: same.

• app/Console/Commands/FixServerStatus::handle: same.

Three sites, one source of truth.

Tests

7 new tests across two files:

• tests/Feature/Enums/CloudProviderTest.php (5): each provider's default code, plus the config-absent fallback path.
• tests/Feature/Teams/TeamCreationProvisioningTest.php (2): end-to-end team creation through the actual controller — asserting server.region matches the chosen provider for both DO and Hetzner.

Full suite:

php artisan test --compact tests/Feature tests/Unit
Tests:    106 skipped, 686 passed (2223 assertions)
Duration: 23.90s

Pint: clean.

Out of scope

The migration default 'nbg1' is still in the schema. Changing it would require a migration on existing data and isn't necessary now that all create sites set the column explicitly. If the cosmetic schema default bothers you, a follow-up can change the default to 'local' or drop it.

Live E2E status

⚠️ Live E2E not run on this branch — plane wifi too flaky for full DO provision. The feature tests exercise the controller end-to-end so the regression is locked in. Manual verification on stable internet:

1. Create a team on DigitalOcean
2. php artisan tinker --execute='echo App\Models\Server::latest()->first()->region;' → expect nyc1
3. Create a team on Hetzner → expect ash

Test plan

• CI green
• Live E2E on stable internet — confirm server.region matches the provider for each cloud