Start testing against Rust edition 2024 #23794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_814864937
branch
from
4d6b45e to
cf1ec3d
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_814864937
branch
4 times, most recently
from
93db786 to
dba0033
Compare
This change also makes all the necessary fixes to get us compatible with edition 2024. I set things up so that we test edition 2024 with Bazel but keep Cargo on edition 2021. This seems like a nice way to go since it allows us to get full test coverage of both editions without us having to increment our minimum supported Rust version. PiperOrigin-RevId: 816241556
copybara-service
bot
force-pushed
the
test_814864937
branch
from
dba0033 to
3ff8329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start testing against Rust edition 2024
This change also makes all the necessary fixes to get us compatible with
edition 2024.
I set things up so that we test edition 2024 with Bazel but keep Cargo on
edition 2021. This seems like a nice way to go since it allows us to get full
test coverage of both editions without us having to increment our minimum
supported Rust version.