Skip to content

Add selected copies of old java gencode for smoke test #23787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Add selected copies of old java gencode for smoke test #23787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions compatibility/smoke/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
load("@rules_java//java:defs.bzl", "java_test")
load("//compatibility/smoke:stale_gencode_smoke_test.bzl", "stale_gencode_smoke_test")

stale_gencode_smoke_test("3.8.0")

stale_gencode_smoke_test("3.11.0")

stale_gencode_smoke_test("3.19.0")

stale_gencode_smoke_test("3.20.0")

stale_gencode_smoke_test("21.12") # Patch release chosen because patches on 21.x added CVE fixes.

stale_gencode_smoke_test("25.8") # Patch release with CVE fixes and the likely final PBJ 3.x release.

stale_gencode_smoke_test("26.0")

stale_gencode_smoke_test("32.1")
2 changes: 1 addition & 1 deletion compatibility/smoke/proto3_gencode_test.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package legacy_gencode_test.proto3;
option java_outer_classname = "Proto3GencodeTestProto";

message TestMessage {
optional string x = 2;
string x = 2;
NestedTestMessage y = 3;
}

Expand Down
8 changes: 8 additions & 0 deletions compatibility/smoke/v21.12/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
load("@rules_java//java:java_library.bzl", "java_library")

java_library(
name = "checked_in_gencode",
srcs = glob(["**/*.java"]),
visibility = ["//compatibility:__subpackages__"],
deps = ["//:protobuf_java"],
)
Loading
Loading