Prevent accidental stripping of debug_redact options via import option.
#23778
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ion. Because we use reflection to check this metadata on custom options during debug string redaction, there's nothing enforcing that these options will be linked into the binary. In order to avoid stripping this and leaking PII, we just ban optional dependencies on protos used to annotate sensitive data. PiperOrigin-RevId: 814426143
copybara-service
bot
force-pushed
the
test_814426143
branch
from
dc3a5a1 to
e7ee9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent accidental stripping of
debug_redactoptions via import option.Because we use reflection to check this metadata on custom options during debug string redaction, there's nothing enforcing that these options will be linked into the binary. In order to avoid stripping this and leaking PII, we just ban optional dependencies on protos used to annotate sensitive data.