Remove calls to registerSchemaOverride in TestSchemas and TestSchemasLite #23761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…Lite I believe these are now vestigial and no-op. If we don't register these up-front, they'll get registered later in Protobuf.schemaFor. TestSchemas, TestSchemasLite, and the replacement Protobuf.schemaFor all use `new ManifestSchemaFactory()` to create the schema. So the behaviour should be the same. The tests pass without these. PiperOrigin-RevId: 814081139
copybara-service
bot
force-pushed
the
test_814081139
branch
from
974107f to
a326f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to registerSchemaOverride in TestSchemas and TestSchemasLite
I believe these are now vestigial and no-op. If we don't register these up-front, they'll get registered later in Protobuf.schemaFor.
TestSchemas, TestSchemasLite, and the replacement Protobuf.schemaFor all use
new ManifestSchemaFactory()to create the schema. So the behaviour should be the same.The tests pass without these.