feat(ffi): expose sqlglot_generate_pretty with dialect-aware formatting#24
Open
gauravs wants to merge 1 commit into
Open
feat(ffi): expose sqlglot_generate_pretty with dialect-aware formatting#24gauravs wants to merge 1 commit into
gauravs wants to merge 1 commit into
Conversation
- fix generate_pretty to honor the target dialect (previously ignored) - add Generator::generate_pretty method; deprecate Generator::pretty - add sqlglot_generate_pretty FFI export; update C/C++ examples and docs - bump 0.10.17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pretty-printing to the FFI and fixes
generate_prettyto actually respect the target dialect.Previously
generate_pretty(ast, dialect)ignored itsdialectargument, so formatted output always used source/ANSI quoting instead of the target's.Changes
Before / after
Parsing MySQL and pretty-printing as T-SQL: