Skip to content

CR-006: Add Oracle and TSQL national string literal support for N'...'#13

Merged
yigalrozenberg merged 1 commit into
masterfrom
cr-006-national-string-literal
May 27, 2026
Merged

CR-006: Add Oracle and TSQL national string literal support for N'...'#13
yigalrozenberg merged 1 commit into
masterfrom
cr-006-national-string-literal

Conversation

@yigalrozenberg

Copy link
Copy Markdown
Collaborator

Summary

Adds full support for national string literals with the N prefix across tokenization, parsing, AST, generation, and tests.

Changes

  • Add TokenType::NationalString
  • Tokenize N'...' and n'...' as national string tokens
  • Add Expr::NationalStringLiteral
  • Parse national string tokens into dedicated AST nodes
  • Emit N'...' for Oracle/TSQL and plain strings for other dialects
  • Update optimizer, type annotation, executor, and dialect transform handling
  • Add tokenizer and transpile tests for roundtrip and cross-dialect behavior
  • Update CLI cast expectation to current Postgres output style

Validation

  • cargo test -q passes

Related

  • CR-006
  • PSQ-2379
  • PSQ-1473

@yigalrozenberg
yigalrozenberg merged commit 9c02c3f into master May 27, 2026
4 checks passed
@yigalrozenberg
yigalrozenberg deleted the cr-006-national-string-literal branch May 27, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant