fix: parse ANSI typed string literals (DATE/TIMESTAMP/TIME 'x') - #12
Merged
Merged
Conversation
Parse DATE 'x', TIMESTAMP 'x', and TIME 'x' as Expr::Cast instead of mis-parsing them as a bare column reference followed by an orphaned string literal. Generator emits the ANSI typed-string form for all dialects except MySQL family (which uses CAST(...) form). Fixes CR-003 / PSQ-2244.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CR-003 / PSQ-2244.
The parser did not recognize ANSI SQL typed string literals (
DATE '2024-01-01',TIMESTAMP '...',TIME '...'). They were mis-parsed as a bare column reference (Expr::Column { name: "DATE" }) followed by an orphaned string literal, producing malformed output (e.g.,SELECT DATE, '2024-01-01' FROM DUAL).Changes
Parser (
src/parser/sql_parser.rs):parse_primary()— when aDATE/TIMESTAMP/TIMESTAMP WITH TIME ZONE/TIMEtoken is followed by a string literal, produceExpr::Cast.Generator (
src/generator/sql_generator.rs):Expr::Castarm — emitsDATE 'x'for all dialects except MySQL family (which usesCAST('x' AS DATE)).Tests:
Roundtrip Behavior
DATE '2024-01-01'DATE '2024-01-01'CAST('2024-01-01' AS DATE)TIMESTAMP '2024-06-15 10:30:00'TIMESTAMP '2024-06-15 10:30:00'CAST('...' AS TIMESTAMP)TIME '10:30:00'TIME '10:30:00'CAST('10:30:00' AS TIME)