Skip to content

Refactor aes encryptor - #72

Merged
sofia-tekdatum merged 2 commits into
dev_phase2from
refactor_aes_encryptor
Aug 21, 2025
Merged

Refactor aes encryptor#72
sofia-tekdatum merged 2 commits into
dev_phase2from
refactor_aes_encryptor

Conversation

@sofia-tekdatum

@sofia-tekdatum sofia-tekdatum commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Continuing with the AesEncryptor refactor.

In this next step I rename everything related to encryption_internal as aes_encryption.

Updating all the includes, tests and CMake files.

Verified all encryption unit tests work:
parquet-encryption-key-management-test
parquet-encryption-test

This removes a lot of confusion, as there are encryption_internal and internal_file_encryptor files.

In the next PR I can make the intended change, which is to have the AesEncryptors inherit from the new EncryptorInterface.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@argmarco-tkd argmarco-tkd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much for this refactor! it makes the code sooo much easier to navigate and understand!

@sofia-tekdatum
sofia-tekdatum force-pushed the refactor_aes_encryptor branch from 1ae10e5 to f89f2a6 Compare August 21, 2025 04:26
@sofia-tekdatum
sofia-tekdatum changed the base branch from refactor_encryption_utils to dev_phase2 August 21, 2025 04:27
@sofia-tekdatum

Copy link
Copy Markdown
Collaborator Author

Testing update:

Ran
From cpp/build:
./release/parquet-encryption-test
./release/parquet-encryption-key-management-test
./release/arrow-dataset-file-parquet-encryption-test

From python:
python -m pytest pyarrow/tests/parquet/test_encryption.py
python -m pytest pyarrow/tests/parquet/test_external_encryption.py
python -m pytest pyarrow/tests/test_dataset_encryption.py

All passed.

@sofia-tekdatum
sofia-tekdatum merged commit ada63b9 into dev_phase2 Aug 21, 2025
13 of 37 checks passed
@sofia-tekdatum
sofia-tekdatum deleted the refactor_aes_encryptor branch September 20, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor classes in preparation for External encryptor (fx neutral) > Change AesEncryptor to use new interface

3 participants