Refactor aes encryptor - #72
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
argmarco-tkd
left a comment
There was a problem hiding this comment.
LGTM. Thank you so much for this refactor! it makes the code sooo much easier to navigate and understand!
1ae10e5 to
f89f2a6
Compare
|
Testing update: Ran From python: All passed. |
Continuing with the AesEncryptor refactor.
In this next step I rename everything related to encryption_internal as aes_encryption.
Updating all the includes, tests and CMake files.
Verified all encryption unit tests work:
parquet-encryption-key-management-test
parquet-encryption-test
This removes a lot of confusion, as there are encryption_internal and internal_file_encryptor files.
In the next PR I can make the intended change, which is to have the AesEncryptors inherit from the new EncryptorInterface.