Add external enum#35
Merged
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
sofia-tekdatum
requested review from
argmarco-tkd,
avalerio-tkd and
cristekdatum
avalerio-tkd
reviewed
Aug 7, 2025
avalerio-tkd
approved these changes
Aug 8, 2025
avalerio-tkd
left a comment
avalerio-tkd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the clarifications.
This was
linked to
issues
Aug 8, 2025
Closed
This was
unlinked from
issues
Aug 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new enum value for the External DBPA Encryptor.
This change requires us to use thrift generated code. After modifying parquet_thrift and thrift_internal, the command needed to regenerate the code is:
cd cpp
./build-support/update-thrift.sh