Updating to the latest version of DBPS tag#257
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
2891b8a to
d97ff9e
Compare
avalerio-tkd
left a comment
There was a problem hiding this comment.
Thanks @argmarco-tkd for this and the testing.
Just for my reference, we don't need to update manually any of the common files from DBPS here, right? I had in the back of my head the dbps_interface.h, enums.h, and maybe another, but that's no longer needed, I think?
| #TODO: Change to a specific tag/commit when we have one. | ||
| #https://github.com/protegrity/arrow/issues/179 | ||
| GIT_TAG 6206fb0e27556a0df9160364caa3819e4af3fe0f | ||
| GIT_TAG cd2ed09312c8041c814f7d5479004a32e5dea6ff |
There was a problem hiding this comment.
Would we like a named tag for this instead? That may be useful to mark more explicitly the deliverable?
There was a problem hiding this comment.
We should, but let's have a quick offline chat about this first.
In short, no, we don't need to do that. |
d97ff9e to
2ff4b83
Compare
|
Thanks for this! |
Updating to the latest version of DBPS tag
Testing
ctest -L parquet)