Skip to content

Updating to the latest version of DBPS tag#257

Merged
argmarco-tkd merged 1 commit into
mainfrom
dev_dbps_tag_update
Mar 24, 2026
Merged

Updating to the latest version of DBPS tag#257
argmarco-tkd merged 1 commit into
mainfrom
dev_dbps_tag_update

Conversation

@argmarco-tkd

Copy link
Copy Markdown
Collaborator

Updating to the latest version of DBPS tag

Testing

  • All unit tests pass (via ctest -L parquet)
  • Successful Manual testing (using correctness verification script) against local + remote instances of DBPA.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@avalerio-tkd avalerio-tkd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @argmarco-tkd for this and the testing.

Just for my reference, we don't need to update manually any of the common files from DBPS here, right? I had in the back of my head the dbps_interface.h, enums.h, and maybe another, but that's no longer needed, I think?

Comment thread cpp/src/parquet/CMakeLists.txt Outdated
#TODO: Change to a specific tag/commit when we have one.
#https://github.com/protegrity/arrow/issues/179
GIT_TAG 6206fb0e27556a0df9160364caa3819e4af3fe0f
GIT_TAG cd2ed09312c8041c814f7d5479004a32e5dea6ff

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we like a named tag for this instead? That may be useful to mark more explicitly the deliverable?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should, but let's have a quick offline chat about this first.

@argmarco-tkd

Copy link
Copy Markdown
Collaborator Author

Thanks @argmarco-tkd for this and the testing.

Just for my reference, we don't need to update manually any of the common files from DBPS here, right? I had in the back of my head the dbps_interface.h, enums.h, and maybe another, but that's no longer needed, I think?

In short, no, we don't need to do that.
Earlier in the project (before we had the automated setup to download DBPS header files) we had to update DBPS-sourced headers. But now that we have automated downloads we do not need to update those files by hand. The only case where we'd need to update anything other than the tag in CMakeLists.txt is there the interface (contained in dbpa_interface.h was updated - in that case we'd have to make the Arrow code comply with the new version of the interface.

@argmarco-tkd argmarco-tkd merged commit 2ff4b83 into main Mar 24, 2026
34 of 98 checks passed
@argmarco-tkd argmarco-tkd deleted the dev_dbps_tag_update branch March 24, 2026 17:40
@avalerio-tkd

Copy link
Copy Markdown
Collaborator

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distribution > Link the Arrow code to a specific tag of DBPS (for importing header files)

3 participants