Skip to content

Adding DictionaryPage properties to EncodingProperties#254

Merged
argmarco-tkd merged 1 commit into
mainfrom
dev_dictionary_properties
Mar 12, 2026
Merged

Adding DictionaryPage properties to EncodingProperties#254
argmarco-tkd merged 1 commit into
mainfrom
dev_dictionary_properties

Conversation

@argmarco-tkd

@argmarco-tkd argmarco-tkd commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Adding DictionaryPage properties to EncodingProperties

Two properties belonging to Dictionary Pages were missing from EncodingProperties. In this PR we add them. These are the properties:

  • Dictionary Page NumValues (dict_page_num_values)
  • Dictionary Page "is sorted" (optional) (dict_page_is_sorted)

Testing

  • Existing and modified unit tests pass (via ctest -L parquet)
  • Successful manual testing using base_app.py (both for non-dictionary pages and dictionary pages).

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@argmarco-tkd argmarco-tkd marked this pull request as ready for review March 12, 2026 21:53

@avalerio-tkd avalerio-tkd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@argmarco-tkd argmarco-tkd merged commit 8e5bee4 into main Mar 12, 2026
35 of 101 checks passed
@argmarco-tkd argmarco-tkd deleted the dev_dictionary_properties branch March 12, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants