Skip to content

Testing JNI macos compilation #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofia-tekdatum merged 7 commits into from
Feb 6, 2026
Merged

Testing JNI macos compilation #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cec7f54
Testing JNI macos compilation
sofia-tekdatum Jan 27, 2026
25d0d64
Second attempt at fix
sofia-tekdatum Jan 27, 2026
e74d29e
Trying fix for boost problem
sofia-tekdatum Jan 27, 2026
5e18b4b
Trying fix for boost problem
sofia-tekdatum Jan 27, 2026
184d669
Removing flakiness odds from dbpa_executor_test
sofia-tekdatum Jan 27, 2026
2cc348d
Removing flakiness odds from dbpa_executor_test
sofia-tekdatum Jan 28, 2026
e537be1
Better timeout values
sofia-tekdatum Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/cpp_extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ jobs:
-B cpp.build \
--preset=ninja-release-jni-macos \
-DARROW_BUILD_TESTS=ON \
-DARROW_BUILD_SHARED=ON \
-DPARQUET_REQUIRE_ENCRYPTION=ON \
-DPARQUET_BUILD_DBPS_LIBS=OFF \
-DCMAKE_INSTALL_PREFIX=$PWD/cpp.install
- name: Build
run: |
Expand Down
24 changes: 12 additions & 12 deletions cpp/src/parquet/encryption/external/dbpa_executor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,21 +392,21 @@ TEST_F(DBPAExecutorTest, TimeoutExceptionThrownOnSlowOperation) {
void init(std::string, std::map<std::string, std::string>, std::string, std::string,
Type::type, std::optional<int>, CompressionCodec::type,
std::optional<std::map<std::string, std::string>>) override {
// Simulate slow operation that takes 200ms
std::this_thread::sleep_for(std::chrono::milliseconds(100));
// Simulate slow operation that takes 2s
std::this_thread::sleep_for(std::chrono::milliseconds(2000));
}

std::unique_ptr<EncryptionResult> Encrypt(
span<const uint8_t>, std::map<std::string, std::string>) override {
// Simulate slow operation that takes 150ms
std::this_thread::sleep_for(std::chrono::milliseconds(100));
// Simulate slow operation that takes 2s
std::this_thread::sleep_for(std::chrono::milliseconds(2000));
return nullptr;
}

std::unique_ptr<DecryptionResult> Decrypt(
span<const uint8_t>, std::map<std::string, std::string>) override {
// Simulate slow operation that takes 120ms
std::this_thread::sleep_for(std::chrono::milliseconds(100));
// Simulate slow operation that takes 2s
std::this_thread::sleep_for(std::chrono::milliseconds(2000));
return nullptr;
}
};
Expand All @@ -415,9 +415,9 @@ TEST_F(DBPAExecutorTest, TimeoutExceptionThrownOnSlowOperation) {
auto slow_agent = std::make_unique<SlowMockAgent>();
auto timeout_executor =
std::make_unique<DBPAExecutor>(std::move(slow_agent),
50, // init timeout: 50ms (will timeout)
55, // encrypt timeout: 50ms (will timeout)
60); // decrypt timeout: 50ms (will timeout)
5, // init timeout: 5ms (will timeout)
5, // encrypt timeout: 5ms (will timeout)
5); // decrypt timeout: 5ms (will timeout)

// Test init timeout - should throw DBPAExecutorTimeoutException
try {
Expand All @@ -429,7 +429,7 @@ TEST_F(DBPAExecutorTest, TimeoutExceptionThrownOnSlowOperation) {
// Verify the timeout exception contains expected information
std::string error_msg = e.what();
EXPECT_TRUE(error_msg.find("init") != std::string::npos);
EXPECT_TRUE(error_msg.find("50") != std::string::npos);
EXPECT_TRUE(error_msg.find("5") != std::string::npos);
EXPECT_TRUE(error_msg.find("milliseconds") != std::string::npos);
} catch (...) {
FAIL() << "Expected DBPAExecutorTimeoutException, but got different exception type";
Expand All @@ -446,7 +446,7 @@ TEST_F(DBPAExecutorTest, TimeoutExceptionThrownOnSlowOperation) {
// Verify the timeout exception contains expected information
std::string error_msg = e.what();
EXPECT_TRUE(error_msg.find("encrypt") != std::string::npos);
EXPECT_TRUE(error_msg.find("55") != std::string::npos);
EXPECT_TRUE(error_msg.find("5") != std::string::npos);
EXPECT_TRUE(error_msg.find("milliseconds") != std::string::npos);
} catch (...) {
FAIL() << "Expected DBPAExecutorTimeoutException, but got different exception type";
Expand All @@ -460,7 +460,7 @@ TEST_F(DBPAExecutorTest, TimeoutExceptionThrownOnSlowOperation) {
// Verify the timeout exception contains expected information
std::string error_msg = e.what();
EXPECT_TRUE(error_msg.find("decrypt") != std::string::npos);
EXPECT_TRUE(error_msg.find("60") != std::string::npos);
EXPECT_TRUE(error_msg.find("5") != std::string::npos);
EXPECT_TRUE(error_msg.find("milliseconds") != std::string::npos);
} catch (...) {
FAIL() << "Expected DBPAExecutorTimeoutException, but got different exception type";
Expand Down
Loading