Skip to content

Refactoring constructors and make methods to remove unused encoding - #232

Merged
sofia-tekdatum merged 2 commits into
mainfrom
cleanup_constructor
Jan 10, 2026
Merged

Refactoring constructors and make methods to remove unused encoding#232
sofia-tekdatum merged 2 commits into
mainfrom
cleanup_constructor

Conversation

@sofia-tekdatum

Copy link
Copy Markdown

The encoding is page level information, not column-level information. This is captured at the page level and set in the UpdateEncryptorMetadata method, so removing from the Make and constructor methods.

Verified all tests pass and the base_app does the right thing.

…rom the column-level information. This is captured at the page level and set in the UpdateEncryptorMetadata method
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@argmarco-tkd argmarco-tkd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this - LGTM, ship it!

@sofia-tekdatum
sofia-tekdatum merged commit c23dcd6 into main Jan 10, 2026
32 of 101 checks passed
@sofia-tekdatum
sofia-tekdatum deleted the cleanup_constructor branch January 24, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup > Clean up Encryptor/Decryptor interface

2 participants