Renaming 'connection_config' to 'configuration_properties' - #229
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
argmarco-tkd
force-pushed
the
rename_connection_config
branch
from
January 7, 2026 21:32
63fff65 to
28341e2
Compare
argmarco-tkd
marked this pull request as ready for review
January 7, 2026 22:27
argmarco-tkd
commented
Jan 7, 2026
| if constexpr (std::is_void_v<ReturnType>) { | ||
| future.get(); | ||
| ARROW_LOG(DEBUG) << "[DBPAExecutor] SUCCESS: " << operation_name << " completed successfully"; | ||
| ARROW_LOG(DEBUG) << "[DBPAExecutor] COMPLETED: " << operation_name << " operation."; |
Author
There was a problem hiding this comment.
slightly unrelated change to help clarify logging.
| } else { | ||
| auto result = future.get(); | ||
| ARROW_LOG(DEBUG) << "[DBPAExecutor] SUCCESS: " << operation_name << " completed successfully"; | ||
| ARROW_LOG(DEBUG) << "[DBPAExecutor] COMPLETED: " << operation_name << " operation."; |
| # "encryption_algorithm": "EXTERNAL_DBPA_V1", | ||
| # "encryption_key": "has_subscription_key" | ||
| # } | ||
| }, |
Author
There was a problem hiding this comment.
unrelated minor change which got rolled in.
avalerio-tkd
approved these changes
Jan 8, 2026
avalerio-tkd
left a comment
avalerio-tkd
left a comment
There was a problem hiding this comment.
LGTM. This looks like a straight renaming, so should be all good. Thanks for the change!
sofia-tekdatum
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming
connection_configtoconfiguration_properties(C++, Python, Cython code)Testing
ctest -L parquet)base_app.py(both for local and remote DBPA agent)