Merge all the things - #221
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
argmarco-tkd
left a comment
There was a problem hiding this comment.
Thank you for this. This is massive! (not a criticism, just a statement!)
Overall LGTM.
I only skimmed the cython code (unfamiliar with it), and the encryption/external code (assuming that's a copy/paste). For the rest, took a bit of a deeper look and did not find anything concerning - with one exception/note: for thrift auto-generated files, it did look like we downgraded the version of the thrift compiler. Left a note.
Left a couple of other minor comments around.
Thanks again!
| check(2547339, 0xffffffffffffffffULL); | ||
| } | ||
|
|
||
| TEST(TestIsParquetCipherSupported, SupportedCiphers) { |
There was a problem hiding this comment.
based on the types.cc file, I see that completeness of this is important. let's create a ticket to create an additional test (using magic enum, alredy imported into the project) to verify completeness.
There was a problem hiding this comment.
…test version of DBPA interface
… from the compiler
… a regression test
…e sanitizer to be unhappy
Merge dev_phase2 into main.
Main is up to date with Arrow release version 22.0