First implementation for ExternalEncryptionConfiguration

[cristekdatum]

Introducing the new ExternalEncryptionConfiguration request in #24

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[cristekdatum]

@sofia-tekdatum I found this code at the existing Encryptor

as you can notice here is where column_keys changes to string format before get into the C++ code. I want to check if you still wan to use this pattern for the app_context

[sofia-tekdatum]

@sofia-tekdatum I found this code at the existing Encryptor <img alt="image" width="1593" height="549"
as you can notice here is where column_keys changes to string format before get into the C++ code. I want to check if you still wan to use this pattern for the app_context

Yes, we want that string passed as is all the way to the ExternalEncryptorImpl

[sofia-tekdatum]

Then here, we shouldn't be doing a new call at all, but rather a self.external_config.reset

[cristekdatum]

This is important to above errors during the destruction of the objects when the test ends. But I will see if the changes in the previous comment works there is a possibility to make this change

[sofia-tekdatum]

nit: add space after comma

[sofia-tekdatum]

Also print the value here as in the @Property exception above.

[sofia-tekdatum]

Define separate test methods for each test case you want to create.

i.e. one for EncryptionConfiguration only
Another for ExternalEncryptionConfiguration with correct params
Another for ExternalEncryptionConfiguration with a poorly formed json

Don't just test the "sunny" cases.

[sofia-tekdatum]

Thanks!