Adding external dependencies to parquet/encryption/external/third_party

[argmarco-tkd]

Bringing in external dependencies (header files) into parquet/encryption/external/third_party

These will be used in a later PR. Additionally, these will eventually be moved out of this directory (#110)

This work is part of a series of PRs created to merge the "DLL Loading" work into dev_phase.
This work was already reviewed when "DLL Loading" (PR #37) was written against dev-miniapp.

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[avalerio-tkd]

Let's use third_party instead of borrowed

Also there's only arrow/cpp/src/parquet/encryption/ on dev_phase2. Do we need external and also third_party nestings ?

[argmarco-tkd]

Will modify to third_party.

Re: external: short answer is yes, we want it. This is the directory where we put DLL-and DBPA-related stuff (e.g. DLL loader). The ExternalDBPAEncryptorAdapter remains in parquet/encryption/external_dbpa_encryption.h.

So structure will be as followes

parquet/encryption/external_dbpa_encryption.h <- ExternalDBPAEncryptorAdapter
parquet/encryption/external/ <- DLL Loading and other related utils for DBPA loading/executing.
parquet/encryption/external/third_party/ <- header files, which eventually will go away #110)

[avalerio-tkd]

Let's create an issue to track this. It may end up being related to the distribution tasks, but let's track it separately.

[argmarco-tkd]

Already have one which covers all new code (#112)

[avalerio-tkd]

I think we have a tracking Issue for this. Can we add a reference to it?

[argmarco-tkd]

It's mentioned in the PR description. Will add a reference in the file as well.

[argmarco-tkd]

Moved the files over to external/third_party - however that caused the specific file comments to disappear. They remain in the "conversation" part of the PR.

[avalerio-tkd]

LGTM. Thanks for the updates.

[argmarco-tkd]

Merged as part of 1ce10de

[argmarco-tkd]

Added as part of 1ce10de