Renamed and refactored connection_config TO configuration_map#203
Merged
Conversation
avalerio-tkd
commented
Dec 20, 2025
avalerio-tkd
commented
Collaborator
- Refactored and rename connection_config_file_path to configuration_map.
- Made configuration_map more generic.
- Remove duplicated and unused misc functions to extract values.
- Made move explicit difference between the configuration map and the connection config file.
- Remove duplicated and unused misc functions to extract values. - Made move explicit difference between the configuration map and the connection config file.
argmarco-tkd
approved these changes
Dec 20, 2025
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Approving, but have a question: from the PR description: Made configuration_map more generic. this is future looking, correct? I did not see any obvious places in the PR where extra functionality/extra concepts were being added to the configuration_map member.
Collaborator
Author
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.