Update encryption metadata to support different encrypt_modes for Dictionary vs Pages#193
Merged
Conversation
avalerio-tkd
commented
Dec 10, 2025
avalerio-tkd
commented
Collaborator
- Updated encryption mode keys to use different keys for dictionary page and data page.
- Fixes an issue upstream where the encryption mode value was different in case of dictionary encodings.
…age and data page. - Fixes an issue upstream where the encryption mode value was different in case of dictionary encodings.
Comment on lines
+41
to
+42
| constexpr const char* ENCRYPTION_MODE_DICTIONARY_PAGE = "encrypt_mode_dict_page"; | ||
| constexpr const char* ENCRYPTION_MODE_DATA_PAGE = "encrypt_mode_data_page"; |
Collaborator
There was a problem hiding this comment.
we should have "KEY" in the names for these.
argmarco-tkd
approved these changes
Dec 10, 2025
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, LGTM. Please see note on the naming of the new constants.
No need for a new PR if/when addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.