Tighten up fallback to per-block encryption on Encryption sequencer#189
Conversation
avalerio-tkd
commented
Dec 8, 2025
avalerio-tkd
commented
- On Encryption Sequencer, declare explicitly the conditions to allow fallback to per-block encryption.
- Cleanup use of DBPSUnsupportedException across util functions.
… fallback to per-block encryption. - Cleanup use of DBPSUnsupportedException across util functions.
|
|
||
| namespace dbps::compression { | ||
|
|
||
| // TODO(Issue #188): Add support for other compressions. |
There was a problem hiding this comment.
if this is something we want to tackle as part of the project, keep the TODO. if it's a future extension, I recommend removing the todo.
| compression_ == CompressionCodec::SNAPPY); | ||
|
|
||
| // Format: Only PLAIN is supported | ||
| // TODO(Issue #187): Add support for other encodings. |
There was a problem hiding this comment.
similar to above - let's keep the TODO only if it's work we plan to complete in the project. Else, let's move these as notes for the future.
There was a problem hiding this comment.
nit: can we move these two statements closer to the code which performs per-value encryption?
There was a problem hiding this comment.
This is the only place possible with the current code structure. We'll discuss that offline.
avalerio-tkd
left a comment
avalerio-tkd
left a comment
There was a problem hiding this comment.
Thanks for the review. Let's chat offline a bit about the structure of the ConvertAndEncrypt try-catch.
|
|
||
| namespace dbps::compression { | ||
|
|
||
| // TODO(Issue #188): Add support for other compressions. |
| compression_ == CompressionCodec::SNAPPY); | ||
|
|
||
| // Format: Only PLAIN is supported | ||
| // TODO(Issue #187): Add support for other encodings. |
There was a problem hiding this comment.
This is the only place possible with the current code structure. We'll discuss that offline.
…llback. - Moved setting per-value metadata closer to the rest of the code.
|
Thanks @argmarco-tkd for the review. Could you PTAL? |
2 participants
