Enable per_value result on encryption Sequencer + Updated testing script to cover more combinations.#186
Merged
Merged
Conversation
(1) Compression SNAPPY (2) Page type: Dictionary, Data_page_v1, Data_page_v2 (3) Encoding: PLAIN (any others are unsupported) (4) DataType: BYTE_ARRAY, floats, FIXED_LEN_BYTE_ARRAY - This is a temporary update to the testing script. A rewrite of this script is planned to tidy it up.
avalerio-tkd
requested review from
argmarco-tkd and
sofia-tekdatum
and removed request for
argmarco-tkd and
sofia-tekdatum
Collaborator
Author
|
@argmarco-tkd @sofia-tekdatum, gonna merge this without review to enable the encryption Sequencing code, which is the only change. Made an untidy update to the testing script to check for more combinations. Will add an Issue and implement a proper test or full rewrite of the testing script. The good news is that the full per_value flow is working, tested with the script with various combinations of compression/data_page_versions/encoding/datatype. So I enable it, and future calls will go through the per_value route instead of falling back to per_block. But this is still preliminary testing. We need to do a more thorough test with Arrow / base_app / etc etc. But we'll get to that. Thanks very much to both for the busy sprint! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update of test script to add:
(1) Compression SNAPPY
(2) Page type: Dictionary, Data_page_v1, Data_page_v2
(3) Encoding: PLAIN (any others are unsupported)
(4) DataType: BYTE_ARRAY, floats, FIXED_LEN_BYTE_ARRAY
This is a temporary update to the testing script. A rewrite of this script is planned to tidy it up.