Implement CompressionAndJoin to complete the Decryption sequence#185
Merged
Conversation
avalerio-tkd
commented
Dec 7, 2025
avalerio-tkd
commented
Collaborator
- Implement CompressAndJoin.
- Adding unittests.
- Adding unittests.
argmarco-tkd
reviewed
Dec 7, 2025
| EXPECT_EQ(joined, value_bytes); | ||
| } | ||
|
|
||
| TEST(ParquetUtils, CompressAndJoin_UnsupportedCompression) { |
Collaborator
There was a problem hiding this comment.
do we need a similar test ("throws") for unsupported encoding?
Collaborator
Author
There was a problem hiding this comment.
Added. Thanks.
argmarco-tkd
approved these changes
Dec 7, 2025
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this - the final piece! - LGTM, ship it!
Collaborator
Author
Thanks for the reviews. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.