Adding value_encryption_utils#180
Merged
Merged
Conversation
avalerio-tkd
reviewed
Dec 4, 2025
avalerio-tkd
left a comment
avalerio-tkd
left a comment
Collaborator
There was a problem hiding this comment.
It took me a while to understand it, but I think I got it. Left a few questions to clarify. Thanks!
| // Helper: Convert decrypted byte-vectors into a TypedListValues according to datatype | ||
| TypedListValues BuildTypedListFromDecryptedBytes( | ||
| Type::type datatype, | ||
| const std::vector<std::vector<uint8_t> >& elements_bytes) { |
Collaborator
There was a problem hiding this comment.
To clarify, this is the plain bytes, no longer EncryptedValue or anything else wrapped, right?
argmarco-tkd
force-pushed
the
dev_value_encr_utils
branch
from
50204c7 to
ed1b7aa
Compare
argmarco-tkd
commented
Dec 5, 2025
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
Author
There was a problem hiding this comment.
(test - let's see if with this all the comments are piublished)
avalerio-tkd
reviewed
Dec 5, 2025
avalerio-tkd
approved these changes
Dec 5, 2025
avalerio-tkd
left a comment
avalerio-tkd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this and all the changes! Ship it :)
Collaborator
Author
Thank you! - I know it took extra time to review this one! :) |
argmarco-tkd
force-pushed
the
dev_value_encr_utils
branch
from
2cd1c28 to
4cffaa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding value_encryption_utils (to be used by Encryptor implementations)
Testing