feat: optional .NET SDK install (Desktop & Server)#19
Open
brunovicenteb wants to merge 6 commits into
Open
Conversation
Add --install-dotnet and --install-dotnet=8|9|10 to desktop.sh and server.sh (default .NET 10), APT path with dotnet-install fallback, zsh PATH for ~/.dotnet, docs and version bump to v0.41.7. Add .gitattributes (eol=lf for *.sh) and normalize shell scripts to LF. Made-with: Cursor
Update STEPS titles via update_steps_dotnet_labels() before show_roadmap_and_wait on desktop (step 5) and server (AI CLI Tools). Bump version to v0.41.8, CHANGELOG, and docs. Made-with: Cursor
Probe ~/.dotnet, /usr/bin/dotnet, and /usr/share/dotnet/dotnet; use bash -c with snap/bin in PATH instead of bash -l. Bump version to v0.41.9 and update CHANGELOG and docs. Made-with: Cursor
Consolidate CHANGELOG into one v0.41.7 release; align desktop.sh, server.sh, and documentation (remove intermediate v0.41.8/v0.41.9 version strings). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional .NET SDK installation path to SetupVibe Desktop and Server, controlled by CLI flags, with Linux (APT + fallback script) and macOS (
dotnet-install.sh) support. It also fixes line endings for shell scripts, improves roadmap / final summary labels when .NET is requested or already present, and bumps documentation and version metadata.What’s included
.NET installation
--install-dotnet— installs the .NET SDK with default channel aligned to .NET 10 (LTS).--install-dotnet=8|9|10— installs the chosen major SDK series.--manager(any order).packages-microsoft-prodwhen possible; fallback to officialdotnet-install.shto~/.dotnet.dotnet-install.shunder~/.dotnet.Shell environment
conf/zshrc-*.zsh: if~/.dotnetexists, setsDOTNET_ROOTand extendsPATH(~/.dotnet,~/.dotnet/tools).Roadmap & installation summary
update_steps_dotnet_labels()runs before the interactive roadmap so step titles reflect .NET when:--install-dotnetis passed, ordotnetis detected (paths such as~/.dotnet/dotnet,/usr/bin/dotnet,/usr/share/dotnet/dotnet, plusbash -cwithPATHincludingsnap/bin— avoids fragilebash -l/ missed APT installs).Repository hygiene
.gitattributes:*.sh text eol=lfso Bash on Linux/macOS does not hit$'\r': command not found.Versioning & docs
CHANGELOG.mdentries for the feature, roadmap labels, and .NET detection fix.README,docs/**,AGENTS.md/CLAUDE.md/GEMINI.mdupdated for flags, behaviour, and version.How to test
Desktop (local clone):
Server:
Piped install:
curl -sSL desktop.setupvibe.dev | bash -s -- --install-dotnetAfter install:
dotnet --versionand confirm roadmap / summary show the .NET note when applicable.WSL / clean machine: reset distro or use a fresh VM to re-run the full flow.