Update README.md #740
Open
Update README.md #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows powershell example is added Signed-off-by: mervecingoz <[email protected]>
|
From the KubeCon Contrib Fest. @bwplotka, @ArthurSens and @vesari , I'll take this one. |
|
|
|
Sorry for the delay. I was busy during KubeCon. I'll get to this ASAP. |
beorn7
requested changes
Apr 8, 2025
| @@ -145,6 +145,15 @@ Examples: | |||
|
|
|||
| curl -X PUT http://pushgateway.example.org:9091/api/v1/admin/wipe | |||
|
|
|||
| #### MS Windows Users | |||
There was a problem hiding this comment.
Let's not indent this. I think it looks better without it. Also, we are not really using title case in the sub-titles. And maybe add something like "Note for". In summary:
Suggested change
| #### MS Windows Users | |
| #### Note for MS Windows users |
| @@ -145,6 +145,15 @@ Examples: | |||
|
|
|||
| curl -X PUT http://pushgateway.example.org:9091/api/v1/admin/wipe | |||
|
|
|||
| #### MS Windows Users | |||
| MS Windows users could send http requests to the pushgateway using Powershell. | |||
There was a problem hiding this comment.
I would leave a blank line above this for consistency. Similarly, capitalize "Pushgateway" and "HTTP".
There was a problem hiding this comment.
Final nit: Maybe "can" instead of "could"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows powershell example is added