Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a collection timeout feature to the Node Exporter. Posting the draft PR to get initial feedback, I will add an option to configure the timeout value. This will provide users with the flexibility to adjust the timeout based on their specific needs and environments(scrape timeout)
Need
If the time to collect metrics from any one collector is greater than scrape timeout than None of the other metrics are collected and results in false Node down alerts.
Timeout Implementation
Testing
Ensure that the timeout is enforced correctly and that appropriate logs are generated when a timeout occurs.
Verify that metrics are collected and sent without blocking or errors.