added md disks in down state #3007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -99,6 +99,24 @@ var ( | |||||||||||||
| []string{"device"}, | ||||||||||||||
| nil, | ||||||||||||||
| ) | ||||||||||||||
| blocksSyncedPctDesc = prometheus.NewDesc( | ||||||||||||||
| prometheus.BuildFQName(namespace, "md", "blocks_synced_pct"), | ||||||||||||||
| "Percentage of blocks synced on device.", | ||||||||||||||
| []string{"device"}, | ||||||||||||||
| nil, | ||||||||||||||
| ) | ||||||||||||||
| syncTimeRemainingDesc = prometheus.NewDesc( | ||||||||||||||
| prometheus.BuildFQName(namespace, "md", "sync_time_remaining"), | ||||||||||||||
Finomosec marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||
| "Estimated finishing time for current sync in seconds.", | ||||||||||||||
| []string{"device"}, | ||||||||||||||
| nil, | ||||||||||||||
| ) | ||||||||||||||
| blockSyncedSpeedDesc = prometheus.NewDesc( | ||||||||||||||
| prometheus.BuildFQName(namespace, "md", "blocks_synced_speed"), | ||||||||||||||
| "current sync speed (in Kilobytes/sec)", | ||||||||||||||
| []string{"device"}, | ||||||||||||||
| nil, | ||||||||||||||
| ) | ||||||||||||||
|
Comment on lines
+123
to
+128
Member
There was a problem hiding this comment. This doesn't seem necessary, we should be able to compute this from something like
Suggested change
Author
There was a problem hiding this comment. I think it is usefull. It is the CURRENT speed, as it is shown in /stat/proc/mdstat
Author
There was a problem hiding this comment. My Grafana Board: https://grafana.com/grafana/dashboards/20989-node-exporter-mdadm-status/
Contributor
There was a problem hiding this comment. Note that the groundwork has already been laid for #1085, and we probably should not add any new parsing functionality relating to |
||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error { | ||||||||||||||
|
|
@@ -131,7 +149,13 @@ func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error { | |||||||||||||
| float64(mdStat.DisksTotal), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| ) | ||||||||||||||
| ch <- prometheus.MustNewConstMetric( | ||||||||||||||
| disksDesc, | ||||||||||||||
| prometheus.GaugeValue, | ||||||||||||||
| float64(mdStat.DisksDown), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| "down", | ||||||||||||||
| ) | ||||||||||||||
| ch <- prometheus.MustNewConstMetric( | ||||||||||||||
| disksDesc, | ||||||||||||||
| prometheus.GaugeValue, | ||||||||||||||
|
|
@@ -200,6 +224,25 @@ func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error { | |||||||||||||
| float64(mdStat.BlocksSynced), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| ) | ||||||||||||||
| ch <- prometheus.MustNewConstMetric( | ||||||||||||||
| blocksSyncedPctDesc, | ||||||||||||||
| prometheus.GaugeValue, | ||||||||||||||
| float64(mdStat.BlocksSyncedPct), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| ) | ||||||||||||||
| ch <- prometheus.MustNewConstMetric( | ||||||||||||||
| syncTimeRemainingDesc, | ||||||||||||||
| prometheus.GaugeValue, | ||||||||||||||
| float64(mdStat.BlocksSyncedFinishTime*60), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| ) | ||||||||||||||
| ch <- prometheus.MustNewConstMetric( | ||||||||||||||
| blockSyncedSpeedDesc, | ||||||||||||||
| prometheus.GaugeValue, | ||||||||||||||
| float64(mdStat.BlocksSyncedSpeed), | ||||||||||||||
| mdStat.Name, | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| return nil | ||||||||||||||
|
|
||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.