Fix top-level examples in push.go.#1298
Conversation
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part." Signed-off-by: eduarrrd <[email protected]>
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Proposed more specific example URL, but you are right, thanks!
| // | ||
| // // Easy case: | ||
| // push.New("http://example.org/metrics", "my_job").Gatherer(myRegistry).Push() | ||
| // push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() |
There was a problem hiding this comment.
| // push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() | |
| // push.New("http://pushgateway.example.org", "my_job").Gatherer(myRegistry).Push() |
| // | ||
| // // Complex case: | ||
| // push.New("http://example.org/metrics", "my_job"). | ||
| // push.New("http://example.org/", "my_job"). |
There was a problem hiding this comment.
| // push.New("http://example.org/", "my_job"). | |
| // push.New("http://pushgateway.example.org", "my_job"). |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
👋🏽 Moved to draft, since there are some comments to address, but otherwise it would be nice to have this! Thanks! |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
2 participants
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part."