Fix 'pq: permission denied for function pg_ls_waldir' on PG v16.6 #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khiemdoan Could you please merge this PR? |
|
Hi @kakuiho, |
sysadmind
requested changes
Feb 15, 2025
| @@ -418,6 +418,7 @@ AS | |||
| SELECT * FROM get_pg_stat_statements(); | |||
|
|
|||
| GRANT SELECT ON postgres_exporter.pg_stat_statements TO postgres_exporter; | |||
| GRANT ALL ON FUNCTION pg_catalog.pg_ls_waldir() TO postgres_exporter; | |||
There was a problem hiding this comment.
I always hesitate to recommend someone give ALL permissions. I think this only needs EXECUTE. Can you confirm and update?
There was a problem hiding this comment.
I ran on this comment by chance and did it on my side as I had the error, and it did clear the error from the console when granting only EXECUTE. So I guess it does work 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #1100