[prometheus-operator-admission-webhook] reorder job-patchwebhook #5608
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheRealNoob <[email protected]>
|
tomorrow i will test this out and figure out the error |
Signed-off-by: TheRealNoob <[email protected]>
Signed-off-by: TheRealNoob <[email protected]>
zeritti
requested changes
May 8, 2025
There was a problem hiding this comment.
Thanks, @TheRealNoob, for the change.
I would still prefer making the webhook configurations in to hooks optional only, i.e. the default installation would not install them as hooks. A field like webhooks.configurationsAsHooks (bool), for example, would then be used as a toggle. Enabling the toggle (and jobs) would set the appropriate annotations in both the configurations and the jobs.
| @@ -2,7 +2,7 @@ | |||
| apiVersion: v2 | |||
| description: Prometheus Operator Admission Webhook | |||
| name: prometheus-operator-admission-webhook | |||
| version: 0.24.2 | |||
| version: 0.24.3 | |||
There was a problem hiding this comment.
Should really be a minor change.
Suggested change
| version: 0.24.3 | |
| version: 0.25.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Modifies release order of Helm hook jobs. See below issue for deeper description.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])