Feat(blackbox): #4921
Open
Feat(blackbox): #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaskinny
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
Add nodeport option to values Signed-off-by: yaser <[email protected]>
yaskinny
force-pushed
the
feat/blackbox
branch
from
41aa555 to
52b7e7f
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
monotek
requested changes
Feb 4, 2025
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| description: Prometheus Blackbox Exporter | |||
| name: prometheus-blackbox-exporter | |||
| version: 9.0.1 | |||
| version: 9.0.2 | |||
There was a problem hiding this comment.
new feature should raise minor version
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nodeport option to values
What this PR does / why we need it
This update adds a nodePort option to the chart, which is essential for setting a static nodePort number, ensuring consistent releases across different environments. Without this option, Kubernetes assigns the nodePort randomly, which can lead to inconsistencies.
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])