Skip to content

Conversation

Brikaa
Copy link

@Brikaa Brikaa commented Feb 15, 2022

Fixes a bug where the navbar won't re-render if the user signs out while they are on the homepage.

For layout.tsx component

  • Gets rid of AuthState since it is not used in the React element.
  • Adds a state for nav items and passes it to navigation.tsx.

For profile.tsx component

  • Gets rid of onBlur in DropDown since it has no effect.
  • Gets rid of useRef since it is not used.
  • Removes the click event listener on the profile image on signing out to avoid changing the state of a removed component.
  • Uses useEffect() to add and remove event listeners on opening and closing the dropdown

For recent-devs mock

  • Makes the IDs of the recent devs unique to avoid giving errors in the console
  • Uses UTF-8 characters

@Brikaa Brikaa requested a review from a team as a code owner February 15, 2022 12:25
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.38%. Comparing base (2cac0fd) to head (d352038).

Files with missing lines Patch % Lines
src/components/shared/navigation/profile.tsx 40.00% 6 Missing ⚠️
src/components/shared/navigation/navigation.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   60.87%   61.38%   +0.50%     
==========================================
  Files         126      126              
  Lines        1958     2191     +233     
  Branches      380      528     +148     
==========================================
+ Hits         1192     1345     +153     
- Misses        731      840     +109     
+ Partials       35        6      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant