-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 운동 기록 조회 리팩토링 및 스켈레톤 구현 #386 #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0f061d4
refactor: 운동 기록 id를 navArgs에서 가져오도록 수정 #386
edv-Shin 883e8ef
refactor: 갱신이 필요할 때만 api를 호출하도록 수정 #386
edv-Shin de1ae98
refactor: navArgs로 toolbar 설정 및 리팩토링 #386
edv-Shin 6e16395
feat: 운동 기록 상세조회 페이지 스켈레톤 적용 #386
edv-Shin e35fae4
fix: ktlint 문법 수정 #386
edv-Shin df86536
fix: 테스트코드 수정 #386
edv-Shin a6fc7c9
fix: 테스트코드 수정 #386
edv-Shin ed9fe43
fix: ktlint 문법 수정 #386
edv-Shin 6fb0adb
feat: EdgeToEdge 활성화, imePadding 설정 공통화 #386
edv-Shin d5ca81a
fix: ktlint 문법 수정 #386
edv-Shin 8157524
feat: 프로필 수정 화면에 키보드 하단 패딩 조절 추가 #386
edv-Shin 1534223
feat: 채팅방 키보드 로직 수정 #386
edv-Shin c5cc360
Merge branch 'dev' into feat/loading-386
edv-Shin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,4 +51,7 @@ dependencies { | |
|
|
||
| // lottie animation | ||
| implementation(libs.lottie) | ||
|
|
||
| // Shimmer | ||
| implementation(libs.shimmer) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EdgeToEdge가 활성화 되어있나요?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MainActivity에 활성화 설정을 추가했습니다.
+키보드에 맞게 패딩을 추가하는 로직이 프로필 편집화면에도 필요한 것을 확인했습니다.
하단 패딩 조절 로직을 KeyboardAdjustHelper로 공통화해서 사용할 수 있도록 수정했습니다.
8157524
6fb0adb