Skip to content

Conversation

wang-boyu
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a TypeError in the agents and networks GIS example by correcting function signatures and import statements across multiple RL model implementations.

  • Removes redundant parameters from function signatures that were causing TypeErrors
  • Fixes spelling errors in comments and documentation
  • Updates import statements to use relative imports for proper module resolution

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rl/wolf_sheep/utility.py Removes unnecessary parameters from function signatures and adds proper imports
rl/wolf_sheep/model.py Updates import statement and function calls to match corrected signatures
rl/wolf_sheep/agents.py Changes to relative import for utility module
rl/wolf_sheep/README.md Fixes spelling error in documentation
rl/train.py Replaces unused loop variable with underscore
rl/epstein_civil_violence/utility.py Removes unnecessary parameters and adds imports
rl/epstein_civil_violence/model.py Updates imports and function calls
rl/epstein_civil_violence/agent.py Changes to relative import and fixes spelling
rl/epstein_civil_violence/README.md Fixes spelling error
rl/boltzmann_money/server.py Updates parameter name for consistency
rl/README.md Fixes spelling error
gis/agents_and_networks/src/space/utils.py Adds default parameter values
gis/agents_and_networks/references/GMU-Social.nlogo Multiple spelling corrections

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@EwoutH
Copy link
Member

EwoutH commented Sep 22, 2025

This is basically an example update to Mesa 3.x right?

@wang-boyu
Copy link
Member Author

No just a small fix for one gis example, and some ruff fixes (changing variable names etc) so that pre-commit can pass.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no remarks.

Thanks!

@wang-boyu
Copy link
Member Author

Awesome, thanks Ewout!

@wang-boyu wang-boyu merged commit 130d3d5 into projectmesa:main Sep 26, 2025
3 of 4 checks passed
@wang-boyu wang-boyu deleted the fix/gis-example branch September 26, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants