Skip to content

chore: ruff errors #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

chore: ruff errors #271

merged 2 commits into from
May 21, 2025

Conversation

jchanke
Copy link
Contributor

@jchanke jchanke commented May 19, 2025

the previous few pull requests were failing the ruff tests because of 4 small syntax errors, so this PR fixes them.

hopefully the next few PRs will pass the post-commit ruff checks!

these were the fixed errors and the ruff error messages:

ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

gis/agents_and_networks/src/space/utils.py:60:25: RUF046 Value being cast to `int` is already an integer
   |
58 | def redistribute_vertices(geom, distance):
59 |     if isinstance(geom, LineString):
60 |         if (num_vert := int(round(geom.length / distance))) == 0:
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF046
61 |             num_vert = 1
62 |         return LineString(
   |
   = help: Remove unnecessary `int` call

rl/Tutorials.ipynb:cell 3:2:16: RUF003 Comment contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean ``` (GRAVE ACCENT)?
  |
1 | # ### Step 1: Importing the Necessary Modules
2 | # To begin, let’s import the required modules for the Epstein Civil Violence model:
  |                ^ RUF003
3 |
4 | from epstein_civil_violence.model import EpsteinCivilViolenceRL
  |

rl/Tutorials.ipynb:cell 3:9:7: RUF003 Comment contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean ``` (GRAVE ACCENT)?
   |
 7 | from train import train_model
 8 |
 9 | # Here’s a breakdown of the modules:
   |       ^ RUF003
10 | # - `EpsteinCivilViolenceRL`: Contains the core model and environment.
11 | # - `run_model`: Configures and runs the model for inference.
   |

rl/Tutorials.ipynb:cell 5:4:5: RUF003 Comment contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean ``` (GRAVE ACCENT)?
  |
3 | # To get a feel for how the environment operates, let's run it for a few steps using random actions.
4 | # We’ll sample the action space for these actions:
  |     ^ RUF003
5 |
6 | for _ in range(10):
  |

Found 4 errors.

Copy link

coderabbitai bot commented May 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jchanke jchanke changed the title fix: ruff errors chore: ruff errors May 19, 2025
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 7512f6b into projectmesa:main May 21, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants