Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade bytedance/sonic for go1.24 compat #6093

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gnuletik
Copy link

@gnuletik gnuletik commented Mar 10, 2025

nuclei v3.3.9## Proposed changes

Upgrade bytedance/sonic to v1.13.1 for go 1.24 compatibility.
See https://github.com/bytedance/sonic/releases/tag/v1.13.1

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • Chores
    • Upgraded underlying libraries to benefit from improved performance, reliability, and bug fixes.

@auto-assign auto-assign bot requested a review from dwisiswant0 March 10, 2025 10:45
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

Walkthrough

The update modifies dependency versions in the go.mod file. The version of github.com/bytedance/sonic is changed from v1.12.8 to v1.13.1, and the version of github.com/bytedance/sonic/loader is updated from v0.2.2 to v0.2.4.

Changes

File Change Summary
go.mod Updated dependency versions: github.com/bytedance/sonic from v1.12.8 to v1.13.1 and github.com/bytedance/sonic/loader from v0.2.2 to v0.2.4

Suggested reviewers

  • dogancanbakir
  • Mzack9999

Poem

I'm a little rabbit, hopping through the code,
Upgrading libraries on a special upgrade road.
Sonic and loader now sparkle anew,
With fresh version hops that feel so true.
Celebrating change with a joyful emoji hop! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d6d50d and e754409.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (2 hunks)
🔇 Additional comments (2)
go.mod (2)

62-62: Upgrade sonic dependency to v1.13.1

The dependency upgrade of github.com/bytedance/sonic from v1.12.8 to v1.13.1 meets the PR objective for Go1.24 compatibility. Please verify that any breaking changes or behavioral adjustments introduced in v1.13.1 are accounted for in the codebase (e.g., via relevant documentation or in-code checks).


144-144: Upgrade sonic/loader dependency to v0.2.4

The change updates github.com/bytedance/sonic/loader from v0.2.2 to v0.2.4, aligning with the main sonic upgrade. Ensure that this indirect dependency update does not introduce any unexpected compatibility issues, and update any related documentation if necessary.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GeorginaReeder
Copy link

Thanks for your contribution @gnuletik ! :)

Copy link
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using build constraints, we gotta update those accordingly (json.go & json_fallback.go). But I still need more information - bytedance/sonic#771 (comment), because build constraints can't define an exact Go version strictly.

@gnuletik
Copy link
Author

@dwisiswant0 Do you know when this PR could be merged (with the update of go1.24 build constraints)?

go 1.24.1 was released on 2025-02-11, so most people should have upgraded from go 1.24.0.
cf bytedance/sonic#771 (comment)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants