-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade bytedance/sonic for go1.24 compat #6093
base: dev
Are you sure you want to change the base?
chore: upgrade bytedance/sonic for go1.24 compat #6093
Conversation
WalkthroughThe update modifies dependency versions in the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thanks for your contribution @gnuletik ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using build constraints, we gotta update those accordingly (json.go & json_fallback.go). But I still need more information - bytedance/sonic#771 (comment), because build constraints can't define an exact Go version strictly.
@dwisiswant0 Do you know when this PR could be merged (with the update of go1.24 build constraints)? go 1.24.1 was released on 2025-02-11, so most people should have upgraded from go 1.24.0. Thanks! |
nuclei v3.3.9## Proposed changes
Upgrade bytedance/sonic to v1.13.1 for go 1.24 compatibility.
See https://github.com/bytedance/sonic/releases/tag/v1.13.1
Checklist
Summary by CodeRabbit